Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove idToPkgMap #12564

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

sapphi-red
Copy link
Member

Description

IIUC findNearestPackageData now has a similar cache mechanism with idToPkgMap cache which is used when resolving browser field mapping.
This PR removes idToPkgMap to make the logic simpler.

I tested this PR with #6030 and the performance wasn't degraded.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label Mar 24, 2023
@stackblitz
Copy link

stackblitz bot commented Mar 24, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

One thing we should review later is how these packages are used. We were discussing with @bluwy that the pkg.hasSideEffects call in the resolve plugin looks off. They are using the package of the importer and I think they need to be using the package of the resolved id.

@patak-dev patak-dev merged commit a326ec8 into vitejs:main Mar 24, 2023
@sapphi-red sapphi-red deleted the refactor/remove-id-to-pkg-map branch March 24, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants