Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): watch env files creating and deleting (fix #12127) #12129

Merged
merged 1 commit into from
Feb 23, 2023
Merged

fix(server): watch env files creating and deleting (fix #12127) #12129

merged 1 commit into from
Feb 23, 2023

Conversation

sun0day
Copy link
Member

@sun0day sun0day commented Feb 21, 2023

Description

fix #12127

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

bluwy
bluwy approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice and clean 👍

@bluwy bluwy merged commit cc3724f into vitejs:main Feb 23, 2023
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
@sun0day @futurGH
fix(server): watch env files creating and deleting (fix vitejs#12127) (…
a35628f 
…vitejs#12129)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Creating or deleting an .env file does not restart the dev server
2 participants
@sun0day @bluwy