Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(legacy): bump peer dependency #11277

Closed
wants to merge 1 commit into from
Closed

chore(legacy): bump peer dependency #11277

wants to merge 1 commit into from

Conversation

kingyue737
Copy link
Contributor

Description

As plugin-legacy v3 is for vite v4, I think we should also bump the peer dependency.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev
Copy link
Member

thanks @kingyue737, sorry missed this PR, already updated it here #11278

@patak-dev patak-dev closed this Dec 9, 2022
@kingyue737 kingyue737 deleted the patch-1 branch December 9, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kingyue737 @patak-dev