Skip to content

Named export is not defined when used destructuring an object #9585

Closed
@inakiabt

Description

@inakiabt

Describe the bug

Note: Found this issue testing my app with vitest. I've asked in vitest repo in case it was an issue on their side, but seems it is not.

Looks like imported named exports are not being correctly transformed when used in object desctructuring while building for SSR (this is what vitest uses to transform files while testing).

import { createServer } from 'vite';
const server = await createServer({});

const code = `
import { CODE } from './path'

console.log(CODE);

export const func = ({ [CODE]: result }) => result;
`;
const result = await server.ssrTransform(code);

console.log(result.code);

Outputs:

const __vite_ssr_import_0__ = await __vite_ssr_import__("./path");

console.log(__vite_ssr_import_0__.CODE);

const func = ({ [CODE]: result }) => result;
Object.defineProperty(__vite_ssr_exports__, "func", { enumerable: true, configurable: true, get(){ return func }});

As can be seen, CODE is not correctly referenced in line 5.
I would expect to get something like:

const __vite_ssr_import_0__ = await __vite_ssr_import__("./path");

console.log(__vite_ssr_import_0__.CODE);

const func = ({ [__vite_ssr_import_0__.CODE]: result }) => result;
Object.defineProperty(__vite_ssr_exports__, "func", { enumerable: true, configurable: true, get(){ return func }});

Originally posted by @inakiabt in vitest-dev/vitest#1789

Reproduction

https://stackblitz.com/edit/node-h31zjx?file=index.js

System Info

System:
    OS: macOS 12.5
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
    Memory: 795.55 MB / 16.00 GB
    Shell: 5.1.16 - /usr/local/bin/bash
  Binaries:
    Node: 16.10.0 - ~/.nvm/versions/node/v16.10.0/bin/node
    npm: 7.24.0 - ~/.nvm/versions/node/v16.10.0/bin/npm
    Watchman: 2022.07.04.00 - /usr/local/bin/watchman
  Browsers:
    Chrome: 103.0.5060.134
    Firefox: 102.0.1
    Safari: 15.6
  npmPackages:
    vite: ^2.9.14 => 2.9.14 
    vitest: ^0.20.3 => 0.20.3

Used Package Manager

npm

Logs

No response

Validations

Metadata

Metadata

Assignees

No one assigned

    Labels

    feat: ssrp3-downstream-blockerBlocking the downstream ecosystem to work properly (priority)

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions