Un-deprecate the `vite optimize` command

[soetz]

Description

Hey, the vite optimize command was deprecated in #19348 and I was wondering if it’s possible to reconsider this decision. Here’s my use-case for it:

We use Cypress’ component tests and sometimes run into this issue: cypress-io/cypress#22557

My strategy to avoid it is to have the CI optimize the deps in an early stage of the pipeline (right after installing the deps) and cache the node_modules/.vite folder. Then Cypress can re-use the optimized deps and the Vite server doesn’t restart (which would cause the current test to fail).

Technically, it would be possible to start the dev server and kill the process after some time, but that’s way clunkier than having a dedicated command that exits after it’s done.

I can totally prepare a PR for it (well, it would basically revert 2906048, unless I’ve missed something).

Thanks!

Suggested solution

Make vite optimize not deprecated anymore.

Alternative

No response

Additional context

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

[patak-dev]

I think it was good to deprecate this command as it only optimizes the deps for the client. We need a new command that would optimize deps for all environments. The deps optimizer may change quite a bit once vite migrates to bundled dev using rolldown so it may not be a good moment to introduce a new command.

If the deprecation warning is bothering cypress users, I think the best would be to undeprecate the command and we can have a future considering breaking change instead for now.

[sapphi-red]

I wonder why vite optimize works in your case.

The reload happens when a dependency was not found by crawling the static imports. But the vite optimize command also crawls the static imports in the same way. So there shouldn't be any dependencies that are only found by vite optimize.

One potential reason is that the crawl entry is not set correctly by Cypress. In that case, setting optimizeDeps.entries for Cypress runs might help.

But even with that, vite optimize won't work if you have a dependency only imported from a dynamic imported module. To support that case, we'll need a more advanced command than vite optimize that crawls the whole graph instead of only the static imports.

[soetz]

Huh, I’m confused now. I wasn’t aware that static and dynamic imports are treated differently.

Honestly, it’s a fix that we’ve introduced into our codebase recently, so it’s very possible that it was only "placebo".

I’m going to close this issue and explore a bit more. Thanks for your input!