-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
Closed
Labels
p4-importantViolate documented behavior or significantly improves performance (priority)Violate documented behavior or significantly improves performance (priority)regressionThe issue only appears after a new releaseThe issue only appears after a new release
Description
Describe the bug
when conditional expression exists in new URL
's string literal, dev server & build breaks, with this error message [plugin:vite:asset-import-meta-url] Unterminated template literal (1:11)
Reproduction
https://stackblitz.com/edit/vitejs-vite-c6quvn?file=main.js
Steps to reproduce
vite 4.3.1 works fine, 4.3.5 breaks
const bool = false
// const logo = new URL(`./${bool ? `javascript` : "javascript"}.svg`, import.meta.url).href; // works
const logo = new URL(`./${bool ? "javascript" : "javascript"}.svg`, import.meta.url).href; // doesn't work
toggle comments in above to see the error
System Info
System:
OS: Linux 5.0 undefined
CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
Memory: 0 Bytes / 0 Bytes
Shell: 1.0 - /bin/jsh
Binaries:
Node: 16.14.2 - /usr/local/bin/node
Yarn: 1.22.19 - /usr/local/bin/yarn
npm: 7.17.0 - /usr/local/bin/npm
npmPackages:
vite: ^4.3.5 => 4.3.5
Used Package Manager
npm
Logs
No response
Validations
- Follow our Code of Conduct
- Read the Contributing Guidelines.
- Read the docs.
- Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
- Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
- Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
- The provided reproduction is a minimal reproducible example of the bug.
Metadata
Metadata
Assignees
Labels
p4-importantViolate documented behavior or significantly improves performance (priority)Violate documented behavior or significantly improves performance (priority)regressionThe issue only appears after a new releaseThe issue only appears after a new release