Skip to content

fix: fix hmr of dynamically loaded vue sfc modules in apps with tailwind #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 19, 2025
Merged

fix: fix hmr of dynamically loaded vue sfc modules in apps with tailwind #702

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e520c1d
fix: fix hmr of dynamically loaded vue sfc modules in apps with tailwind
unshame Nov 15, 2025
971c15c
fix: filter out non-js modules instead of sorting
unshame Nov 17, 2025
07b6cf6
Preemptively filter out non-js modules
unshame Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 13 additions & 14 deletions packages/plugin-vue/src/handleHotUpdate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ import type { ResolvedOptions } from './index'

const debug = _debug('vite:hmr')

const directRequestRE = /(?:\?|&)direct\b/

/**
* Vite-specific HMR handling
*/
Expand All @@ -43,17 +41,19 @@ export async function handleHotUpdate(
const { descriptor } = createDescriptor(file, content, options, true)

let needRerender = false
const nonJsModules = modules.filter((m) => m.type !== 'js')
const jsModules = modules.filter((m) => m.type === 'js')
const affectedModules = new Set<ModuleNode | undefined>(
modules.filter((mod) => mod.type !== 'js'), // this plugin does not handle non-js modules
nonJsModules, // this plugin does not handle non-js modules
)
const mainModule = getMainModule(modules)
const templateModule = modules.find((m) => /type=template/.test(m.url))
const mainModule = getMainModule(jsModules)
const templateModule = jsModules.find((m) => /type=template/.test(m.url))

// trigger resolveScript for descriptor so that we'll have the AST ready
resolveScript(descriptor, options, false, customElement)
const scriptChanged = hasScriptChanged(prevDescriptor, descriptor)
if (scriptChanged) {
affectedModules.add(getScriptModule(modules) || mainModule)
affectedModules.add(getScriptModule(jsModules) || mainModule)
}

if (!isEqualBlock(descriptor.template, prevDescriptor.template)) {
Expand Down Expand Up @@ -95,11 +95,10 @@ export async function handleHotUpdate(
const next = nextStyles[i]
if (!prev || !isEqualBlock(prev, next)) {
didUpdateStyle = true
const mod = modules.find(
const mod = jsModules.find(
(m) =>
m.url.includes(`type=style&index=${i}`) &&
m.url.endsWith(`.${next.lang || 'css'}`) &&
!directRequestRE.test(m.url),
m.url.endsWith(`.${next.lang || 'css'}`),
)
if (mod) {
affectedModules.add(mod)
Expand Down Expand Up @@ -130,7 +129,7 @@ export async function handleHotUpdate(
const prev = prevCustoms[i]
const next = nextCustoms[i]
if (!prev || !isEqualBlock(prev, next)) {
const mod = modules.find((m) =>
const mod = jsModules.find((m) =>
m.url.includes(`type=${prev.type}&index=${i}`),
)
if (mod) {
Expand Down Expand Up @@ -329,9 +328,9 @@ function hasScriptChanged(prev: SFCDescriptor, next: SFCDescriptor): boolean {
return false
}

function getMainModule(modules: ModuleNode[]) {
function getMainModule(jsModules: ModuleNode[]) {
return (
modules
jsModules
.filter((m) => !/type=/.test(m.url) || /type=script/.test(m.url))
// #9341
// We pick the module with the shortest URL in order to pick the module
Expand All @@ -342,8 +341,8 @@ function getMainModule(modules: ModuleNode[]) {
)
}

function getScriptModule(modules: ModuleNode[]) {
return modules.find((m) => /type=script.*&lang\.\w+$/.test(m.url))
function getScriptModule(jsModules: ModuleNode[]) {
return jsModules.find((m) => /type=script.*&lang\.\w+$/.test(m.url))
}

export function handleTypeDepChange(
Expand Down
Loading