Skip to content

fix: skip checking private properties of typeParameters #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yyx990803 merged 4 commits into from
Sep 16, 2024
Merged

fix: skip checking private properties of typeParameters #443

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fb0a835
fix: skip the check typeParameters
edison1105 Sep 14, 2024
243f1c3
chore: add comments
edison1105 Sep 14, 2024
4e7cdcf
chore: update comments
edison1105 Sep 14, 2024
f5f9ab5
chore: minor tweaks
edison1105 Sep 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/plugin-vue/src/handleHotUpdate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,6 @@ function isEqualAst(prev?: t.Statement[], next?: t.Statement[]): boolean {
return prev === next
}

// deep equal, but ignore start/end/loc/range/leadingComments/trailingComments/innerComments
if (prev.length !== next.length) {
return false
}
Expand All @@ -268,6 +267,7 @@ function isEqualAst(prev?: t.Statement[], next?: t.Statement[]): boolean {
const prevNode = prev[i]
const nextNode = next[i]
if (
// deep equal, but ignore start/end/loc/range/leadingComments/trailingComments/innerComments
!deepEqual(prevNode, nextNode, [
'start',
'end',
Expand All @@ -276,6 +276,12 @@ function isEqualAst(prev?: t.Statement[], next?: t.Statement[]): boolean {
'leadingComments',
'trailingComments',
'innerComments',
// https://github.com/vuejs/core/issues/11923
// avoid comparing the following properties of typeParameters
// as it may be imported from 3rd lib and complex to compare
'_ownerScope',
'_resolvedReference',
'_resolvedElements'
])
) {
return false
Expand Down