forked from vitejs/vite
    
        
        - 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 17
 
chore: use oxc module runner transform #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Draft
      
      
            hi-ogawa
  wants to merge
  4
  commits into
  vitejs:rolldown-vite
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
hi-ogawa:feat-oxc-module-runner-transform
  
      
      
   
  
    
  
  
  
 
  
      
    base: rolldown-vite
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Draft
            
            chore: use oxc module runner transform #85
                    hi-ogawa
  wants to merge
  4
  commits into
  vitejs:rolldown-vite
from
hi-ogawa:feat-oxc-module-runner-transform
  
      
      
   
              
            
      
        
          +710
        
        
          −364
        
        
          
        
      
    
  
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
  This was referenced Mar 10, 2025 
      
62d8c94    to
    da2bfe3      
    Compare
  
    
          
commit:   | 
    
f08ac6c    to
    a70a869      
    Compare
  
    3ba2c7e    to
    1c0ea36      
    Compare
  
    
      
        
      
      
  
    15 tasks
  
9bb994c    to
    5546976      
    Compare
  
    4e01dff    to
    92b3ef0      
    Compare
  
    
      
        
      
      
  
    7 tasks
  
b47ac7a    to
    3607409      
    Compare
  
    
    
  graphite-app bot
      pushed a commit
        to oxc-project/oxc
      that referenced
      this pull request
    
      Mar 12, 2025 
    
    
      
  
    
      
    
  
There wasn't a test case for this on Vite, but missing re-export deps is spotted as a test case on Vitest vitest-dev/vitest#7646. I'll add a test case on Vite vitejs/rolldown-vite#85 and the same one is added here.
9ce2683    to
    a974a4a      
    Compare
  
    f7ba0d5    to
    486a056      
    Compare
  
    wip: workaround double createRequire chore: enable back pnpm override fix: fix duplicate createRequire chore: fix overrides ci: trigger preview Revert "ci: trigger preview" This reverts commit 6fb3890. chore: oxc-transform 0.57.0 test: update test and note vitejs#19627 test: test ssrTransform deps
c90496e    to
    98838ff      
    Compare
  
    1d5030a    to
    24787ef      
    Compare
  
    0c1eb9d    to
    37a5392      
    Compare
  
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Description
todo
ssrTransformalone shows an obvious improvement, but it's likely not significant for overall transform pipeline.