This repository was archived by the owner on Mar 19, 2026. It is now read-only.
fix: esbuild plugin converter with empty JS files.#516
Merged
sapphi-red merged 1 commit intovitejs:rolldown-vitefrom Nov 20, 2025
Merged
fix: esbuild plugin converter with empty JS files.#516sapphi-red merged 1 commit intovitejs:rolldown-vitefrom
sapphi-red merged 1 commit intovitejs:rolldown-vitefrom
Conversation
cpojer
changed the title
cpojer
changed the title
cpojer
changed the title
cpojer
changed the title
cpojer
force-pushed
the
fix-plugin-converter
branch
from
acce42c to
f93c5fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When converting an esbuild plugin to a rolldown plugin, we check if the result of the plugin call is "empty". However, if a file is empty, it will throw a
not implementederror even if there is nothing wrong with the plugin.This fixes it to check whether the value is nullable, not if it is an empty string. As a result, rolldown-vite no longer throws during the dependency optimization step.
I tested this by applying this patch to an internal codebase and it no longer throws at this step. The file in question that is being loaded is a random transitive dependency that's empty. Please don't ask me why that's a thing: https://unpkg.com/@standard-schema/spec@1.0.0/dist/index.js