Fixed some issues with the tests #252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 24, 2014 12:29
…shouldn't matter, so I removed the whitespace before checking for equality.
…er, so I went with what the tests wanted. However, the test also had the incorrect date for the timestamp it gave, so I fixed that then redid the return_date function.
…he ENML, switched to str.
vitalyrodnenko
pushed a commit
that referenced
this pull request
Jan 18, 2015
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the tests were (and still are failing), so I went through and fixed some of them. As a sidenote, I suspect that several of tests that are testing out.py are failing because out is still writing to the standard sys.stdout, while the unit tests are using a dummy sys.stdout, but it never gets sent to the 'out' module. Could someone confirm this please? Thanks.