-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for resources (attachments) when creating a note. #113
Conversation
Has support for attaching a resource to an existing note or removing attachments from existing notes also been added? |
No, that has not been implemented but shouldn't be hard to do... This fixes the main usecase of adding resources to new notes. |
Why hasn't this been merged? |
Seems it's not maintained anymore... |
Yeah, so I wrote https://github.com/pjz/notehandler in a day or two. It's functional enough to do what I need, but could easily be extended. PRs accepted :) |
@VitaliyRodnenko since you're around again, maybe you can give this one a look? Thanks. |
Any chance we will se this implemented? It's really useful for scanner automation |
Thx for feedback, I'll solve conflicts and merge that with master. Can't do that immediately because of lack of free time. But I promise not to forget about it. Hope to realize that on weekend. |
That would be awesome! |
Hope that works well, need more time to test it well. But it has been merged with master. |
Hm, I just updated and I see this when trying to create a note:
Could it be related to this or did I do something wrong when I reinstalled? Thanks |
@silviuvulcan getting the same error (NameError: global name 'resources' is not defined) after installing this for the first time today. Can't create any new note |
@silviuvulcan looks like the recent commits messed up the |
Indeed older 4423092 works. My error report was in reply to the resources merge: Cheers, |
Implemented support for adding attachments to a new note using '--resource FILENAME'. The attached files (png/pdf/...) are embedded in the content.
Support for resources in update has not been implemented but should not be too hard to do.