Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for resources (attachments) when creating a note. #113

Closed
wants to merge 1 commit into from

Conversation

ddierickx
Copy link

Implemented support for adding attachments to a new note using '--resource FILENAME'. The attached files (png/pdf/...) are embedded in the content.

Support for resources in update has not been implemented but should not be too hard to do.

@Anbalsilfer
Copy link

Has support for attaching a resource to an existing note or removing attachments from existing notes also been added?

@ddierickx
Copy link
Author

No, that has not been implemented but shouldn't be hard to do... This fixes the main usecase of adding resources to new notes.

@pjz
Copy link

pjz commented Jan 13, 2014

Why hasn't this been merged?

@ddierickx
Copy link
Author

Seems it's not maintained anymore...

@pjz
Copy link

pjz commented Jan 21, 2014

Yeah, so I wrote https://github.com/pjz/notehandler in a day or two. It's functional enough to do what I need, but could easily be extended. PRs accepted :)

@MarioRicalde
Copy link
Contributor

@VitaliyRodnenko since you're around again, maybe you can give this one a look?

Thanks.

@filviu
Copy link

filviu commented Jan 13, 2015

Any chance we will se this implemented? It's really useful for scanner automation

@vitalyrodnenko
Copy link
Owner

Thx for feedback, I'll solve conflicts and merge that with master. Can't do that immediately because of lack of free time. But I promise not to forget about it. Hope to realize that on weekend.

@filviu
Copy link

filviu commented Jan 13, 2015

That would be awesome!

vitalyrodnenko pushed a commit that referenced this pull request Jan 18, 2015
@vitalyrodnenko
Copy link
Owner

Hope that works well, need more time to test it well. But it has been merged with master.

@filviu
Copy link

filviu commented Jan 19, 2015

Hm,

I just updated and I see this when trying to create a note:

geeknote create --title Test1 --content something --resource ftest.pdf
    : Connect to Evernote...Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/geeknote-0.2a-py2.7.egg/geeknote/geeknote.py", line 893, in main
    Notes().create(**ARGS)
  File "/usr/local/lib/python2.7/dist-packages/geeknote-0.2a-py2.7.egg/geeknote/geeknote.py", line 637, in create
    inputData = self._parseInput(title, content, tags, notebook, resource)
  File "/usr/local/lib/python2.7/dist-packages/geeknote-0.2a-py2.7.egg/geeknote/geeknote.py", line 705, in _parseInput
    "resources": resources if resources else [],
NameError: global name 'resources' is not defined

Could it be related to this or did I do something wrong when I reinstalled?

Thanks

@padi
Copy link

padi commented Jan 28, 2015

@silviuvulcan getting the same error (NameError: global name 'resources' is not defined) after installing this for the first time today. Can't create any new note

@padi
Copy link

padi commented Jan 28, 2015

@silviuvulcan looks like the recent commits messed up the master branch. Just checkout at an earlier commit, install and try creating a note again. Not sure which SHA is the latest stable working version, but here's what worked for me: 4423092

@filviu
Copy link

filviu commented Jan 28, 2015

Indeed older 4423092 works. My error report was in reply to the resources merge:
"Hope that works well, need more time to test it well. But it has been merged with master."

Cheers,
Silviu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants