Skip to content

fix: use service account file for vertexai client initialization #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alameyo wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: use service account file for vertexai client initialization #308

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4653eb
fix: use service account file for vertexai client initialization
Alameyo Feb 19, 2026
230d70b
Merge branch 'main' into fix-running-on-vertex-ai
Alameyo Feb 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions codebase_rag/tools/document_analyzer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ def __init__(self, project_root: str) -> None:
if orchestrator_provider == cs.Provider.GOOGLE:
if orchestrator_config.provider_type == cs.GoogleProviderType.VERTEX:
self.client = genai.Client(
vertexai=True,
credentials=orchestrator_config.service_account_file,
Copy link
Contributor

@greptile-apps greptile-apps bot Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent credentials handling with providers/base.py:74-81. The provider implementation converts the service account file path to a credentials object using service_account.Credentials.from_service_account_file(), but this passes the file path string directly. Consider aligning the approach for consistency.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Prompt To Fix With AI 
This is a comment left during a code review.
Path: codebase_rag/tools/document_analyzer.py
Line: 39

Comment:
Inconsistent credentials handling with `providers/base.py:74-81`. The provider implementation converts the service account file path to a credentials object using `service_account.Credentials.from_service_account_file()`, but this passes the file path string directly. Consider aligning the approach for consistency.

<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>

How can I resolve this? If you propose a fix, please make it concise.

project=orchestrator_config.project_id,
location=orchestrator_config.region,
)
Expand Down