refactor(cuid2): leverage markrogoyski/math-php when GMP extension is unavailable #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… unavailable Signed-off-by: Alan Brault <alan.brault@visus.io>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request is a revisitation for the issue #255 where
base_convertcould not handle large arbitrary numbers. The quick fix solution was to make the PHP extension GMP required rather than optional as the suggested library in the issue had an incompatible license.Having a hard dependency on an extension that may not be present in all environments was not really diserable long-term but fortunately the markrogoyski/math-php project has provided a working solution that is license compatible and allows for returning of the
GMPextension to an optional state than being required.