Dimension description #716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ptbrowne
commented
Sep 15, 2022
ptbrowne
commented
- feat: Add tooltip for dimension which have descriptions
- feat: Use drop-shadow for arrow to be included in shadow
- feat: Add dimension tooltip in data table
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
wereHamster
reviewed
Sep 15, 2022
bprusinowski
approved these changes
Sep 15, 2022
Collaborator
bprusinowski
left a comment
bprusinowski
left a comment
There was a problem hiding this comment.
LGTM! But I think we are missing the table implementation 😅
ptbrowne
force-pushed
the
fix/tooltip-description
branch
from
e6aff4c to
17dd441
Compare
Collaborator
Author
|
Fixed the overflow issue and added the table implementation (along with a refactor to try to clean things up, and have better types). |
ptbrowne
force-pushed
the
fix/tooltip-description
branch
from
17dd441 to
f287d08
Compare
wereHamster
reviewed
Sep 17, 2022
| import { makeStyles } from "@mui/styles"; | ||
| import { hcl, ScaleLinear } from "d3"; | ||
| import * as React from "react"; | ||
| import React from "react"; |
Contributor
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.