Fix undefined array key REMOTE_USER warning in init()#13
Open
magicsunday wants to merge 1 commit intovisol:mainfrom
Open
Fix undefined array key REMOTE_USER warning in init()#13magicsunday wants to merge 1 commit intovisol:mainfrom
magicsunday wants to merge 1 commit intovisol:mainfrom
Conversation
When no Shibboleth session is active, $_SERVER['REMOTE_USER'] is not set, causing a PHP Warning on every backend request. Use the null coalescing operator to default to null, which is already supported by the ?string property type and handled by all callers via empty() checks. Fixes visol#12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Undefined array key "REMOTE_USER"inShibbolethAuthenticationService::init()when no Shibboleth session is activeProblem
Every non-Shibboleth request to the TYPO3 backend triggers:
Solution
Use the null coalescing operator to default
$this->remoteUsertonullwhen$_SERVER['REMOTE_USER']is not set. This is safe because:?stringnull/empty viaempty($this->remoteUser)Fixes #12