Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mili Material Edge Lines #19919

Draft
wants to merge 37 commits into
base: 3.4RC
Choose a base branch
from
Draft

Mili Material Edge Lines #19919

wants to merge 37 commits into from

Conversation

JustinPrivitera
Copy link
Member

Description

Resolves #

Type of change

  • Bug fix~~
  • New feature~~
  • Documentation update~~
  • Other~~

How Has This Been Tested?

Reminders:

  • Please follow the style guidelines of this project.
  • Please perform a self-review of your code before submitting a PR and asking others to review it.
  • Please assign reviewers (see VisIt's PR procedures for more information).

Checklist:

  • I have commented my code where applicable.~~
  • I have updated the release notes.~~
  • I have made corresponding changes to the documentation.~~
  • I have added debugging support to my changes.~~
  • I have added tests that prove my fix is effective or that my feature works.~~
  • I have confirmed new and existing unit tests pass locally with my changes.~~
  • I have added new baselines for any new tests to the repo.~~
  • I have NOT made any changes to protocol or public interfaces in an RC branch.~~

@JustinPrivitera
this time its for real
3c17db2
@JustinPrivitera
remove todo
68abbde
@JustinPrivitera
super far with no MPI
5d70b2d
@JustinPrivitera
closed to solving this in serial
b6e271c
@JustinPrivitera
closed to solving this in serial
8363ab4
@JustinPrivitera
activatetimestep not being called is solved
3134590
@JustinPrivitera
solved in serial
c5ebd92
@JustinPrivitera
calculate max label
755811e
@JustinPrivitera
actually solve in serial
d6cb524
@JustinPrivitera
clean up
e04ee23
@JustinPrivitera
refactor to one big loop over meshids
7c14647
@JustinPrivitera
trying to end dependence on std::Set
86dd6e8
@JustinPrivitera
no more sets
25690a8
@JustinPrivitera
optimize
b9ae1ed
@JustinPrivitera
logic to split up the domains
d673376
@JustinPrivitera
we are so ready for mpi
e414606
@JustinPrivitera
mpi code is written, but does it work?
3463ab3
@JustinPrivitera
attempting to add test but running into trouble with the older tests
1ee2407
@JustinPrivitera
Merge branch '3.4RC' into task/JustinPrivitera/09_09_24/mili_mat_edge…
9c4d3d4 
…_lines_once_and_4_all
@JustinPrivitera
nullptr
2551f06
@JustinPrivitera
have to be done today
affd9c9
@JustinPrivitera
solve issue of disappearing zones
fece020
@JustinPrivitera
njightmare
ddc3dfd
@JustinPrivitera
the night is darkest just before the dawn
4c50de7
@JustinPrivitera
O BRAVE NEW WORLD
8e8dfe8
@JustinPrivitera
goodbye parallel
9fbbab9
@JustinPrivitera
the sandman rises again
8def731
@JustinPrivitera
this was already done with gross C code
9b068fc
@JustinPrivitera
protect against bad node labels
280d9e6
@JustinPrivitera
notes and prints
d50bd08
@JustinPrivitera JustinPrivitera changed the title Task/justin privitera/09 09 24/mili mat edge lines once and 4 all Mili Material Edge Lines Oct 18, 2024
@JustinPrivitera
Copy link
Member Author

Is a single bool that lives in avtMiliFileFormat.h sufficient to catch node ids not being read? Are there strange parallel cases that could mess us up here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JustinPrivitera