Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Include properties in FeatureCollection example #2425

Merged
merged 5 commits into from
Dec 13, 2024

Conversation

Johngeorgesample
Copy link
Contributor

I tried copy/pasting the example for Native Mapbox Layers, but encountered a TypeScript error.

[tsserver 2741] [E] Property 'properties' is missing in type '{ type: "Feature"; geometry: { type: "Point"; coordinates: number[]; }; }' but required in type 'Feature<Geometry, GeoJsonProperties>'.

This PR addresses that error by adding properties to the object.

Copy link
Contributor

@chrisgervang chrisgervang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Had no idea this was a historical site https://noehill.com/sf/landmarks/sf092.asp

@chrisgervang chrisgervang merged commit cec6970 into visgl:master Dec 13, 2024
2 checks passed
@Johngeorgesample Johngeorgesample deleted the custom-data-ts branch December 14, 2024 01:41
chrisgervang added a commit that referenced this pull request Dec 19, 2024
* inlude `properties` in example for TS

---------

Co-authored-by: Chris Gervang <chrisgervang@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants