update ControlPosition #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usefulthink
reviewed
Nov 9, 2023
|
Awesome, thanks a lot. Merging this right away. |
|
Dang, I just noticed that the values are duplicated for aliases ( |
|
I don't love enums, so I'm fine with making it an object if that works for you. Will come back to this later today. |
|
Perfect, let's do this. |
MauricioRobayo
commented
Nov 9, 2023
| BLOCK_END_INLINE_CENTER: 24, | ||
| BLOCK_END_INLINE_END: 25 | ||
| } as const; | ||
| export type ControlPosition = |
There was a problem hiding this comment.
Not sure about the naming convention here, should I use a different name to distinguish between the type and the object?
There was a problem hiding this comment.
I've seen that recommended elsewhere and it seems to work exactly like the enums, so let's do the same name..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the ControlPosition enum according to this: #67 (comment)
Fixes #67