fix: set infowindow anchor to null during component unmount #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usefulthink
requested changes
May 29, 2024
| @@ -67,7 +72,9 @@ export const InfoWindow = (props: PropsWithChildren<InfoWindowProps>) => { | |||
| } | |||
|
|
|||
| // intentionally shadowing the state variables here | |||
| const infoWindow = new google.maps.InfoWindow(infoWindowOptions); | |||
| const infoWindow = new google.maps.InfoWindow( | |||
There was a problem hiding this comment.
I think this deserves a comment explaining why there's a need to access this undocumented property.
|
I'll close this in favor of #393, I'll make sure to list you as Co-Author there :) |
thanks for fixing this so fast 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #386
I had to do a bit of type coercion as
@types/google.mapsdoesn't actually expose all the properties on the resulting object when you create a newgoogle.maps.InfoWindow