Skip to content

[v9] Pass clearColor to luma RenderPass from MaskPass #8248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 15, 2023
Merged

[v9] Pass clearColor to luma RenderPass from MaskPass #8248

merged 3 commits into from
Nov 15, 2023

Conversation

@felixpalmer
Copy link
Collaborator

@felixpalmer felixpalmer commented Nov 2, 2023

Background

luma.gl defaults the clearColor to [0,0,0,0] in RenderPass which overrides the value set in withGLParameters

Change List

  • Explicitly pass clearColor prop to luma RenderPass

@felixpalmer felixpalmer requested a review from ibgreen November 2, 2023 10:30
@felixpalmer felixpalmer mentioned this pull request Nov 3, 2023
Merged
Base automatically changed from felix/vertexPositions-getBounds to master November 14, 2023 09:25
@felixpalmer felixpalmer merged commit ba63823 into master Nov 15, 2023
@felixpalmer felixpalmer deleted the felix/mask-extension-v9 branch November 15, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ibgreen ibgreen Awaiting requested review from ibgreen

1 more reviewer

@alasarr alasarr alasarr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@felixpalmer @alasarr