Repository navigation
Conversation
Above zoom 12 GlobeView draws with a WebMercatorViewport, so MVTLayer draws its tiles in tile-relative CARTESIAN space with a y-flipped modelMatrix. The flip reverses the triangle winding and GlobeView's default `cullMode: 'back'` drops every polygon fill. Turn culling off on that path; layer parameters still win.
 [Medium impact] The PR appears safe to merge; the fix reaches high-zoom globe tiles and preserves explicit user settings. Summary
No actionable issues found. Tests were not run during this review. Reviews (1) · Last reviewed commit: "fix(geo-layers): MVTLayer fills culled b..." · Reviewed by Greptile |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10866
Change List
MVTLayer:cullMode: 'none'on the tile-relative path; layerparametersstill winThe repro from the issue at zoom 15. Left 9.4.0, right with this change applied.
Related: #10869 fixes
VectorTileLayerMVT tiles on the globe up to zoom 12.