Repository navigation
test(render): drop strokes from terrain-extension-drape - #10845
Draft
chrisgervang wants to merge 1 commit into
Draft
chrisgervang wants to merge 1 commit into
chrisgervang wants to merge 1 commit into
Conversation
Draping strokes under SwiftShader took several hundred ms of GPU time per terrain tile, making this the slowest render test. Golden image regenerated without strokes.
Collaborator
Author
|
I'd prefer to go with solving a root cause in #10851 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
terrain-extension-drapewas the slowest test in CI (21.9s), mostly GPU time spent draping the GeoJsonLayer strokes into each terrain tile's cover texture under SwiftShader.Change List
terrain-extension-drapedrapes fills only (stroked: false)terrain-extension-drape.pngregenerated without strokes