Repository navigation
Conversation
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: af78af8874
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Follow up of #10802
Background
Custom projection sizing guesses source units from CRS strings. This series adopts math.gl alpha.15 through an optional adapter, adaptive bitmap UV meshes, and path/polygon ring subdivision in three independent PRs.
Change List
@deck.gl/core/projectionconverter factoryVerified with
yarn,yarn build, andyarn lint. Passed 3 focused adapter tests.Note
Medium Risk
Changes coordinate conversion contracts and meter sizing for custom projections, but the new path is optional and guarded by strict CRS/axis validation.
Overview
Adds an optional
@deck.gl/core/projectionentry that exposescreateProjectionConverter, which builds math.glProjectionTransforminstances ahead of time and wraps them in deck’sProjectionConvertershape (syncforward/inverse, height preserved). The main@deck.gl/corebundle does not pull in the projection engine; consumers opt in via an optional peer on@math.gl/projectionalpha.15.The factory normalizes loaders.gl/math.gl CRS descriptors, enforces longitude/latitude or east/north/up order, requires a planar meter target, and rejects lossy transforms. It attaches
sourceCoordinates(kind, unit scale, ellipsoid) soCustomProjectionViewportcan size layers from declared units (degrees, radians, feet) instead of guessing fromfromCrsstrings.Docs cover the adapter usage and limitations; vitest pre-bundles math.gl projection deps for the new adapter tests.
Reviewed by Cursor Bugbot for commit 6c9d093. Bugbot is set up for automated code reviews on this repo. Configure here.