Skip to content

chore: add examples to Yarn workspaces - #10605

Open
ibgreen wants to merge 1 commit into
ib/yarn-4-migrationfrom
ib/yarn-4-workspaces
Open

chore: add examples to Yarn workspaces#10605
ibgreen wants to merge 1 commit into
ib/yarn-4-migrationfrom
ib/yarn-4-workspaces

Conversation

@ibgreen

@ibgreen ibgreen commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

Adds the package-managed examples to the Yarn 4 workspace graph, stacked on #10604.

Changes

  • Expand root workspaces from modules/* to include examples/**.
  • Add the root deck.gl resolution pins needed for local workspace linking.
  • Remove redundant per-example installs from the gallery build scripts.
  • Add missing gallery workspace metadata and resolve the duplicate pydeck workspace name.
  • Make the root TypeScript toolchain explicit so Yarn 4 hoisting selects the version required by the build tools.
  • Regenerate the root lockfile for the complete workspace graph.

Validation

  • yarn install --immutable passes with all example and module workspaces.
  • yarn workspaces list --json reports unique workspace names.
  • yarn lint passes.
  • The full build reaches an existing TypeScript error in modules/layers/src/solid-polygon-layer/polygon.ts unrelated to this migration.

@greptile-apps

greptile-apps Bot commented Aug 28, 2026

Copy link
Copy Markdown

Greptile Summary

Adds package-managed examples to the Yarn 4 workspace graph and updates dependency resolution and build setup accordingly.

  • Adds workspace metadata and unique names for the gallery and pydeck examples.
  • Pins local deck.gl package resolutions and makes the root TypeScript dependency explicit.
  • Removes redundant gallery installs from website build scripts and regenerates the workspace lockfile.

Confidence Score: 5/5

The PR appears safe to merge because no blocking failure remains.

No blocking failure remains.

Important Files Changed

Filename Overview
package.json Expands the workspace graph, simplifies bootstrap, and adds explicit TypeScript and deck.gl resolution entries without an eligible follow-up defect.
examples/gallery/package.json Adds unique private-workspace metadata so the gallery participates in the root installation.
examples/pydeck/package.json Renames the workspace to eliminate the reported package-name collision.
website/scripts/build.sh Relies on the root workspace installation for gallery dependencies; checked CI build paths perform that installation first.
website/scripts/test-build.sh Removes the redundant gallery install from the test build, whose root caller installs workspaces first.
yarn.lock Regenerates dependency and workspace entries for the expanded Yarn workspace graph.

Reviews (3): Last reviewed commit: "chore: add examples to Yarn workspaces" | Re-trigger Greptile

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 52a993d797

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread package.json
@ibgreen
ibgreen force-pushed the ib/yarn-4-migration branch from 94aa35d to b83c072 Compare August 28, 2026 18:40
@ibgreen
ibgreen force-pushed the ib/yarn-4-workspaces branch from 52a993d to bd815da Compare August 28, 2026 18:40
@ibgreen
ibgreen force-pushed the ib/yarn-4-migration branch from b83c072 to 1b156a2 Compare August 28, 2026 19:23
@ibgreen
ibgreen force-pushed the ib/yarn-4-workspaces branch from bd815da to 888fbca Compare August 28, 2026 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant