feat(extensions): support ClipExtension on WebGPU - #10565
Closed
ibgreen-openai wants to merge 1 commit into
Closed
Conversation
|
|
||
| const SHADER_HOOKS_WGSL = [ | ||
| // Not yet supported | ||
| 'vs:CLIP_POSITION(position: ptr<function, vec4<f32>>, geometryCoordinates: vec2<f32>, instanceCoordinates: vec2<f32>)', |
Collaborator
There was a problem hiding this comment.
Why not use the same hook names as WebGL: FILTER_POSITION / FILTER_COLOR? Does it make sense to insert hooks into every layer only for a specific extension?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Enable the clipping path that MVTLayer needs to render on WebGPU.
This is a stacked follow-up to #10564, which contains the general binary-geometry and WebGPU vertex-buffer fixes. Its base should be changed to
masterafter that prerequisite merges.Changes
mergeShadersclipShaderPluginfor ClipExtension on WebGPUValidation
yarn lintnpx vitest run --project headless test/modules/core/utils/shader.spec.ts test/modules/extensions/clip.spec.ts— 3 tests passedRENDER_TEST_DEVICE=webgpu npx vitest run --project render test/render/test-cases/mvt-layer.spec.ts— 6 passed, 1 backend group skippedRENDER_TEST_DEVICE=webgl npx vitest run --project render test/render/test-cases/mvt-layer.spec.ts— 6 passed, 1 backend group skippedyarn buildcompleted both the WebGL-only and WebGPU TypeScript/declaration/package builds; its finallerna run buildphase was blocked by an unrelated Nx duplicate-project-name collision among external Codex worktrees