Skip to content

fix(mapbox): guard getProjection against throw when map style is not ready #10551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
waterWang wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −1
Open

fix(mapbox): guard getProjection against throw when map style is not ready #10551

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion modules/mapbox/src/deck-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,17 @@ export function drawLayerGroup(
}

export function getProjection(map: Map): 'mercator' | 'globe' {
const projection = map.getProjection?.();
let projection;
try {
projection = map.getProjection?.();
} catch {
// map.getProjection() can throw if the map's style is not yet assigned
// (e.g. maplibre-gl's Map.prototype.getProjection() calls
// this.style.getProjection() without a guard on this.style).
// Return 'mercator' as the safe default — callers expect this when
// the map is not ready yet.
return 'mercator';
}
const type =
// maplibre projection spec
projection?.type ||
Expand Down