fix(layers): WebGPU derivative-based normal calculation - #10547
Merged
Conversation
|
coverage: 84.084% (-0.003%) from 84.087% — x/normal-fix into master |
ibgreen
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
WebGL and WebGPU use opposite screen-space Y-axis orientations, which reverses the direction of the Y derivative. In GLSL,
cross(dFdx(position), dFdy(position))reconstructs the expected outward-facing surface normal, but applying the same operand order to WGSL’sdpdxanddpdyproduces its inverse. Reversing the operands tocross(dpdy(position), dpdx(position))compensates for that coordinate-system difference, restoring outward-facing normals and therefore the correct diffuse and specular lighting. Geometry with supplied normals is unaffected; this only corrects normals reconstructed from screen-space derivatives.Change List