feat(pydeck): register GlobeView canonical alias in jupyter-widget#10451
Open
chrisgervang wants to merge 1 commit into
Open
feat(pydeck): register GlobeView canonical alias in jupyter-widget#10451chrisgervang wants to merge 1 commit into
chrisgervang wants to merge 1 commit into
Conversation
Add a GlobeView alias to the jupyter-widget JSON converter catalog so pydeck users can write View(type="GlobeView") instead of the experimental View(type="_GlobeView"). The alias follows the existing underscore-export aliasing precedent (StatsWidget, etc.). The _GlobeView name stays registered for backwards compatibility. - create-deck.js: alias GlobeView -> deckExports._GlobeView - examples/globe_view.py: use canonical GlobeView type - create-deck.spec.ts: assert both GlobeView and _GlobeView hydrate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let pydeck users reference deck.gl's globe view under its canonical name —
View(type="GlobeView")— instead of the experimentalView(type="_GlobeView").The jupyter-widget catalog only auto-registers
_GlobeViewunder its underscore name, so canonical names need a manual alias (same precedent asStatsWidget, etc.). This is purely additive:_GlobeViewstays registered, so existing payloads keep working.Changes
create-deck.js— addGlobeView: deckExports._GlobeViewto the converter catalogexamples/globe_view.py— use canonicaltype="GlobeView"create-deck.spec.ts— assert bothGlobeViewand_GlobeViewhydrateValidation
Not run:
yarn build,yarn lint, vitest — no Node runtime in the working environment.yarn vitest run test/modules/jupyter-widget/create-deck.spec.tsshould confirm the new tests.