Skip to content

fix: Avoid crashing playground example when typing layers, views etc #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 25, 2024
Merged

fix: Avoid crashing playground example when typing layers, views etc #192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 18 additions & 7 deletions examples/playground/src/json-configuration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
// This configuration object determines which deck.gl classes are accessible in Playground

// deck.gl
import {MapView, FirstPersonView, OrbitView, OrthographicView} from '@deck.gl/core';
import {MapView, FirstPersonView, OrbitView, OrthographicView, View, Layer} from '@deck.gl/core';
import {COORDINATE_SYSTEM} from '@deck.gl/core';
import * as Layers from '@deck.gl/layers';
import * as AggregationLayers from '@deck.gl/aggregation-layers';
Expand All @@ -22,10 +22,7 @@ import {CSVLoader} from '@loaders.gl/csv';
import {DracoWorkerLoader} from '@loaders.gl/draco';
import {Tiles3DLoader, CesiumIonLoader} from '@loaders.gl/3d-tiles';

const LOADERS = [
CSVLoader,
DracoWorkerLoader
]
const LOADERS = [CSVLoader, DracoWorkerLoader];

// Note: deck already registers JSONLoader...
registerLoaders(LOADERS);
Expand All @@ -52,7 +49,7 @@ export const JSON_CONFIGURATION = {
// community layer modules
...CommunityLayers,
...EditableLayers,
...GraphLayers,
...GraphLayers
// ArrowLayers,
},

Expand All @@ -62,12 +59,26 @@ export const JSON_CONFIGURATION = {
// Enumerations that should be available to JSON parser
// Will be resolved as `<enum-name>.<enum-value>`
enumerations: {
COORDINATE_SYSTEM,
COORDINATE_SYSTEM
},

// Constants that should be resolved with the provided values by JSON converter
constants: {
Tiles3DLoader,
CesiumIonLoader
},

postProcessConvertedJson: (json) => {
// Filter out invalid props. Typically, props will be invalid while the user is typing.
if (json.layers) {
json.layers = json.layers.filter((layer) => layer instanceof Layer);
}
if (json.widgets) {
json.widgets = json.widgets.filter((widget) => typeof widget.onAdd === 'function');
}
if (json.views && !(json.views instanceof View)) {
json.views = json.views.filter((view) => view instanceof View);
}
return json;
}
};
Loading