Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance enhancements, util refactor and and clean up tests #153

Merged
merged 28 commits into from
Jun 7, 2024

Conversation

sygao
Copy link
Contributor

@sygao sygao commented May 23, 2024

Performance enhancements

  • Replace initialization event store read with filename check
  • Utilize event index cache in Repo.index_otus()
  • Utilize event index cache in Repo.iter_otus()

Fixes

  • Repo._iter_events() and .get_source_event_ids() now handle chaff files

Utils refactor

  • Move Molecule to virtool_cli.utils.models
  • MoveMolType, Strandedness and Topology to utils.models and replace relevant duplicate enums in ncbi.models
  • Move utils.console.console, utils.id_generator.generate_random_alphanumeric() and .generate_unique_ids to legacy.utils
    • test_utils_hashing() moved to legacy utils test dir
  • Move utils.format, .ncbi, .storage to utils.deprecated submodule

Clean up tests

  • Replace test files in src_test with current EventSourcedRepo files
  • Move old src_test files to prototype_src_test dir
  • Remove prototype test_utils_storage and test_utils_reference

Add larger-scale add test

  • Add test_add_bulk
  • Add more demo Genbank and Taxonomy files to cache_test

@sygao sygao marked this pull request as ready for review May 23, 2024 21:06
@sygao sygao requested a review from igboyes as a code owner May 23, 2024 21:06
Copy link
Member

@igboyes igboyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This deprecated stuff should just be removed. Is there something stopping you?

@sygao
Copy link
Contributor Author

sygao commented Jun 7, 2024

This deprecated stuff should just be removed. Is there something stopping you?

I just moved the last of the utils, so not anymore.

@igboyes igboyes merged commit f3d28df into alpha Jun 7, 2024
3 of 5 checks passed
@igboyes igboyes deleted the cleanup-streamline branch June 7, 2024 23:18
@sygao sygao restored the cleanup-streamline branch June 10, 2024 17:40
@sygao sygao deleted the cleanup-streamline branch June 10, 2024 18:20
@virtool-bot
Copy link

🎉 This PR is included in version 2.0.0-alpha.31 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants