Change default value of --guest-features to 0x1 #44
Conversation
Due to a [discussion happening in the linux kernel mailing list](https://lore.kernel.org/kvm/20240314024952.w6n6ol5hjzqayn2g@amd.com/T/), it is expected that the default guest features should no longer include `DEBUG_SWAP` by default. This changes the default value back to `0x1` to comply with those changes. Resolves virtee#43 Signed-off-by: Larry Dewey <larry.dewey@amd.com>
larrydewey
requested review from
dubek,
fitzthum,
ryansavino,
tylerfanelli and
DGonzalezVillal
|
Has this been merged yet? Should we wait before accepting this? |
There was a problem hiding this comment.
LGTM. I second @tylerfanelli's question, but I'm not too worried about versioning since this is just the default value.
|
I'm away, I'll be able to look at this on Wednesday. |
|
I just see that when I merged #32 I forgot to add a changelog entry (I'll add that retroactively soon -- see #45). So now I'm planning the changelog entry for this PR, and I want to tell users in which kernel version the default sev_features value changes - do we know that? Probably 6.10 ? something like: kernel < 6.6 - sev_features=0x1 ??? |
|
Also, @larrydewey can you please change the subject line of the commit - remove the issue number and clarify the change, maybe: |
larrydewey
changed the title
Due to a discussion happening in the linux kernel mailing list, it is expected that the default guest features should no longer include
DEBUG_SWAPby default. This changes the default value back to0x1to comply with those changes.Resolves #43