Skip to content

Commit

Permalink
Mention sqlite3 gem in the Gemfile
Browse files Browse the repository at this point in the history 
- Let's not rely on the fact that PG will be setup on participants
  machines properly. Let's use sqlite3 as fallback.
  • Loading branch information
@prathamesh-sonpatki
prathamesh-sonpatki committed Jan 31, 2016
1 parent 9b00929 commit 6ad10c4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions Gemfile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ gem 'sass-rails', '>= 5.0.3'
gem 'uglifier', '>= 2.7.1'

# database
gem 'sqlite3'
gem 'pg'

# Sprockets support for .es6 files, using babel.
Expand Down
4 changes: 3 additions & 1 deletion Gemfile.lock
View file
Original file line number Diff line number Diff line change
Expand Up @@ -393,6 +393,7 @@ GEM
sprockets-es6 (0.6.2)
babel-transpiler
sprockets (>= 3.0.0)
sqlite3 (1.3.11)
thin (1.6.3)
daemons (~> 1.0, >= 1.0.9)
eventmachine (~> 1.0)
Expand Down Expand Up @@ -454,10 +455,11 @@ DEPENDENCIES
spring
sprockets-es6
sprockets-rails!
sqlite3
thin
uglifier (>= 2.7.1)
unicorn
web-console (~> 2.0)

BUNDLED WITH
1.10.6
1.11.2

7 comments on commit 6ad10c4

@vipulnsward
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove pg in this case.

@prathamesh-sonpatki
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind keeping pg. Added sqlite just so we don't have to debug postgres issues :)

@vipulnsward
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't matter then. Whoever needs pg vs sqlite can change it. Having both doesn't make sense.

@vipulnsward
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prathamesh-sonpatki can you get rid of either one. Currently it was replicating stack from wheel

@prathamesh-sonpatki
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoever needs pg vs sqlite can change it.

We should not waste time over it in workshop. We should promote sqlite for workshop.

@vipulnsward
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, thats what I am saying, get rid of pg then. Keeping it in Gemfile, people are still going to face issue that pg is not installed.

@prathamesh-sonpatki
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Please sign in to comment.