Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

添加配置的时候需要做是否已存在配置校验 #444

Closed
lzw2006 opened this issue Jun 27, 2018 · 0 comments
Closed

添加配置的时候需要做是否已存在配置校验 #444

lzw2006 opened this issue Jun 27, 2018 · 0 comments

Comments

@lzw2006
Copy link
Contributor

lzw2006 commented Jun 27, 2018

“系统配置”项,如加相同配置,建议报“配置已存在” 的错误,而不是直接覆盖现有配置

@lzw2006 lzw2006 added this to the 3.1.0 milestone Jun 27, 2018
@lzw2006 lzw2006 added the done label Jun 27, 2018
lzw2006 referenced this issue Jun 27, 2018
Raise alert when create existed config item

Modifications:
Divide createOrUpdateConfig method into createConfig and updateConfig
@lzw2006 lzw2006 added the bug label Jun 27, 2018
lzw2006 added a commit that referenced this issue Jun 27, 2018
Motivation:
Refactor
lzw2006 added a commit that referenced this issue Jun 27, 2018
Enhance notification

Modifications:
Throw exception if update item is not existed
allen8203 added a commit that referenced this issue Jun 27, 2018
lzw2006 added a commit that referenced this issue Jun 27, 2018
Bug fix

Modifications:
Bug fix
lzw2006 added a commit that referenced this issue Jun 27, 2018
Clean up legacy code

Modifications:
Remove unused controller method
lzw2006 added a commit that referenced this issue Jun 27, 2018
Bug fix

Modifications:
Bug fix
allen8203 added a commit that referenced this issue Jun 27, 2018
@kfchu kfchu closed this as completed Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants