Seal VerificationError and ErrorReason? #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! That seems like a reasonable change to me. Any objections @JonasAlaif? |
|
Looks good to me, when I was looking at this at some point before I also thought that there was some redundancy and would be in favour of merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! We occasionally forget to match cases of
ErrorReason/VerificationError. I think it would be nice ifscalacwarns us of this, so could we seal them?Also, I notice that there are no
ErrorReasons that are not also anAbstractErrorReason, and similarly noVerificationErrors that are not also aAbstractVerificationError(other than one mock), do you think it's a good idea to merge them?