Skip to content

(WIP) Remove tymap #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 19 commits into from
Mar 28, 2022
Merged

(WIP) Remove tymap #899

bors merged 19 commits into from
Mar 28, 2022

Conversation

@Aurel300
Copy link
Member

@Aurel300 Aurel300 commented Mar 8, 2022 •
edited
Loading

(generics improvements)

TODO:

  • remove dead code (definition of SubstMap)
  • remove specs closures collector
  • improve extern specs (make sure usage is valid wrt. generics, forbid specialisations, deal with associated types better)
  • figure out what to do in cases where we used to create an empty tymap or substs
  • resolve all comments marked TODO(tymap)
  • (for a future PR) make sure we can serialise unoptimised MIR
  • (for a future PR) remove generics from VIR

@Aurel300 Aurel300 mentioned this pull request Mar 13, 2022
Merged
4 tasks
@Aurel300 Aurel300 force-pushed the tymap-be-gone branch 4 times, most recently from ee6c1aa to 006f620 Compare March 22, 2022 12:36
@Aurel300 Aurel300 marked this pull request as ready for review March 22, 2022 12:36
vakaras
vakaras reviewed Mar 22, 2022
View reviewed changes
vakaras
vakaras reviewed Mar 22, 2022
View reviewed changes
vakaras
vakaras reviewed Mar 22, 2022
View reviewed changes
vakaras
vakaras approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@vakaras vakaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aurel300 Aurel300 mentioned this pull request Mar 23, 2022
Merged
@Aurel300
Copy link
Member Author

Aurel300 commented Mar 23, 2022

bors r+

This was referenced Mar 24, 2022
Merged
Closed
@Aurel300
Copy link
Member Author

Aurel300 commented Mar 28, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 28, 2022

Build succeeded:

@bors bors bot merged commit b152e5a into viperproject:master Mar 28, 2022
@Aurel300 Aurel300 deleted the tymap-be-gone branch March 28, 2022 22:04
bors bot added a commit that referenced this pull request May 24, 2022
@bors @Aurel300 @JonasAlaif
Merge #901
a1642b8 
901: NFM22 examples r=JonasAlaif a=Aurel300

This is to allow linking the examples online from the paper. PRs to be done before the deadline:

- [x] #686 
- [x] #882 
- [x] #887 
- [x] #899 


Co-authored-by: Aurel Bílý <aurel.bily@gmail.com>
Co-authored-by: Jonas <jonas.fiala.cardiff@gmail.com>
bors bot added a commit that referenced this pull request May 27, 2022
@bors @Aurel300 @JonasAlaif
Merge #901 #972
5a3f296 
901: NFM22 examples r=Aurel300 a=Aurel300

This is to allow linking the examples online from the paper. PRs to be done before the deadline:

- [x] #686 
- [x] #882 
- [x] #887 
- [x] #899 


972: Fix slice with range encoding r=JonasAlaif a=JonasAlaif

Fixes #960
Issue is described there. Not sure if this is the correct way to do the error reporting?
It would be really nice to just have a contract for `index` and `index_mut` and report the error as a precondition violation of those. E.g. I really don't want to hardcode the pledge required for `index_mut` by hand.

Co-authored-by: Aurel Bílý <aurel.bily@gmail.com>
Co-authored-by: Jonas <jonas.fiala.cardiff@gmail.com>
@Aurel300 Aurel300 mentioned this pull request Aug 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vakaras vakaras vakaras approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Aurel300 @vakaras