fix: some problems in input method #587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
asterwyx
commented
Dec 9, 2024
asterwyx
commented
- fix input method not correctly destroyed
- fix text input v2 do not clear focused surface
WInputMethodHelper creates WInputMethodV2, so it should connect to before_destroy to destroy it, not aboutToBeInvalidated.
Send leave when focused surface destroyed.
Focus is cleared after sendLeave, but text input might be disabled by the next disabled event. So input popup surface might appear when there is no focus. This is not allowed. Check focused surface of the enabled text input wherever it's used as a focused text input.
zccrs
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.