receive/handler: update tenant label #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After relabeling_configs section Prometheus drops all labels that start with `__`. Technically we could move adding of `__meta_tenant_id` to `metric_relabel_configs` but then meta-metric like `up` and others do not have that `__meta_tenant_id` because, apparently, Prometheus takes labels from after the `relabel_configs` section. Hence, let's just add something human-readable. It doesn't matter much either way to the user because this label gets removed. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
ignasr
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After relabeling_configs section Prometheus drops all labels that start with
__. Technically we could move adding of__meta_tenant_idtometric_relabel_configsbut then meta-metric likeupand others do not have that__meta_tenant_idbecause, apparently, Prometheus takes labels from after therelabel_configssection. Hence, let's just add something human-readable. It doesn't matter much either way to the user because this label gets removed.