receive: implement worker architecture #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of spawning a goroutine for each individual remote write gRPC request, spawn a fixed number of them and send work over channels. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
ignasr
approved these changes
Jan 5, 2024
niaurys
approved these changes
Jan 5, 2024
krisleipus
reviewed
Jan 5, 2024
pkg/receive/handler.go
Outdated
Comment on lines
1247
to
1250
| if err != nil { | ||
| w.errResult = &err | ||
| } | ||
| w.wg.Done() |
There was a problem hiding this comment.
Maybe chan err for response would be more correct than writing to pointer?
There was a problem hiding this comment.
I don't think there would be any difference but maybe with channels the code would be more Go-like. Let me make the change
Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of spawning a goroutine for each individual remote write gRPC request, spawn a fixed number of them and send work over channels.