Unclean teardown of multiprocessing pool with Python 3.8

[himani1]

Hi,
I am using mgzip.decompress() to decompress a byte string. Following is the warning that gets generated in the logs while using it:

File "/usr/lib/python3.8/multiprocessing/pool.py", line 265, in del
_warn(f"unclosed running multiprocessing pool {self!r}",
ResourceWarning: unclosed running multiprocessing pool <multiprocessing.pool.ThreadPool state=RUN pool_size=1>

[timhughes]

This may be fixed by #12 Try using the code from https://github.com/timhughes/mgzip/tree/tests

[himani1]

@timhughes Thanks for the reply. I tried adding the code snippet:

if self.mode == WRITE:
                self.pool.close()
                self.pool.join()
            elif self.mode == READ:
                self.raw.close()

to the finally block of close(), but this doesn't help. The warning is still there.

[timhughes]

If you post a minimal example of code that triggers the error then I can create a test to try and work it out

…

On Tue, 6 Apr 2021, 10:54 Himani Arora, ***@***.***> wrote: @timhughes <https://github.com/timhughes> Thanks for the reply. I tried adding the code snippet: ``` if self.mode == WRITE: self.pool.close() self.pool.join() elif self.mode == READ: self.raw.close() to the finally block of close(), but this doesn't help. The warning is still there. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#13 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJFZDYAPD5V7AFY5JW4WNLTHLK45ANCNFSM42OD6FNA> .

[timhughes]

Can you try with https://github.com/pgzip/pgzip and if you still have the issue, please raise an issue there.