Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add landing page #306

Merged
merged 1 commit into from
May 31, 2020
Merged

Add landing page #306

merged 1 commit into from
May 31, 2020

Conversation

huonggiangbui
Copy link

Description

Add Landing Page

Fixes #230

Type of change

  • New feature (non-breaking change which adds functionality)

Screenshots

demo

Reviewer: Vinit Shahdeo

@huonggiangbui
Copy link
Author

@amaaniqbal Check the new one

@auto-assign auto-assign bot requested a review from vinitshahdeo May 31, 2020 17:56
PragatiVerma18
PragatiVerma18 approved these changes May 31, 2020
View reviewed changes
Copy link
Contributor

@PragatiVerma18 PragatiVerma18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really great. Good work!!

@huonggiangbui
Copy link
Author

Thanks! Can you merge it and add the label also?

@PragatiVerma18 PragatiVerma18 merged commit 56f695e into vinitshahdeo:feature/frontend May 31, 2020
@PragatiVerma18 PragatiVerma18 added design design task frontend gssoc20 Welcome to GirlScript Summer of Code 2020 medium medium level issue labels May 31, 2020
@huonggiangbui
Copy link
Author

@PragatiVerma18 the issue has the label hard, not medium. Can you change it?

@PragatiVerma18 PragatiVerma18 added hard hard level issue and removed medium medium level issue labels May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PragatiVerma18 PragatiVerma18 PragatiVerma18 approved these changes

@vinitshahdeo vinitshahdeo Awaiting requested review from vinitshahdeo

Assignees

@vinitshahdeo vinitshahdeo

Labels
design design task frontend gssoc20 Welcome to GirlScript Summer of Code 2020 hard hard level issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huonggiangbui @PragatiVerma18 @vinitshahdeo