Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Landing Page Design #213

Merged
merged 2 commits into from
Mar 25, 2020
Merged

Landing Page Design #213

merged 2 commits into from
Mar 25, 2020

Conversation

goyalmuskan
Copy link
Contributor

Description

Adding a new landing page design

Fixes #167

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Reviewer: Vinit Shahdeo

vinitshahdeo
vinitshahdeo requested changes Mar 24, 2020
View reviewed changes
Copy link
Owner

@vinitshahdeo vinitshahdeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@goyalmuskan Just a small edit - change the pricing to docs as it's going to free for use. Rest looks awesome. 👏

@vinitshahdeo vinitshahdeo added gssoc20 Welcome to GirlScript Summer of Code 2020 medium medium level issue labels Mar 24, 2020
@goyalmuskan
Copy link
Contributor Author

I have updated it accordingly @vinitshahdeo, please let me know if there's anything else to change. :)

vinitshahdeo
vinitshahdeo approved these changes Mar 25, 2020
View reviewed changes
Copy link
Owner

@vinitshahdeo vinitshahdeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @goyalmuskan 👏 👏

@vinitshahdeo vinitshahdeo merged commit 7b0748a into vinitshahdeo:feature/frontend Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinitshahdeo vinitshahdeo vinitshahdeo approved these changes

Assignees
No one assigned
Labels
gssoc20 Welcome to GirlScript Summer of Code 2020 medium medium level issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goyalmuskan @vinitshahdeo