Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ayandevelop #209

Closed
wants to merge 65 commits into from
Closed

Ayandevelop #209

wants to merge 65 commits into from

Conversation

ayan-biswas0412
Copy link

@ayan-biswas0412 ayan-biswas0412 commented Mar 22, 2020 •
edited
Loading

Description

I have added the email sign-in process by using google firebase

Fixes # (issue) #194 #5

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Reviewer: Vinit Shahdeo

vinitshahdeo and others added 30 commits February 19, 2020 12:02
@vinitshahdeo
added demo link
34500c3
@vinitshahdeo
changed the footer code-snippet
3ade805
@vinitshahdeo
improved the footer code-snippet
2fb7313
@vinitshahdeo
updated the code-snippet at footer, missing braces
74e14dc
@vinitshahdeo
fixed grammatical typo
7a716f4
@vinitshahdeo
Create weekly-digest.yml
c299e79
@vinitshahdeo
Create auto_assign.yml
904ade7
Format 904ade7
7ae578b
@PragatiVerma18
Added FAQs and resources
c15e42f
@PragatiVerma18
fixed markdown
e5564e6
@vinitshahdeo
Merge pull request #22 from PragatiVerma18/feature/documentation
78bfcaa 
Added FAQs and resources
@vinitshahdeo
beautified README.md
b92a972
@vinitshahdeo
made the ques italics
66ac761
@vinitshahdeo
changed heading style
6a42090
@vinitshahdeo
changed heading style for issues section
bd9009c
@vinitshahdeo
added mentor's list
4fbc4d4
@vinitshahdeo
Added gssoc logo
0f8c088
@vinitshahdeo
Merge pull request #23 from vinitshahdeo/feature/documentation
26cd921 
Added FAQs + Mentors for GSSoC 2020
@vinitshahdeo
added closed PR badge + changed section name
e533864
@vinitshahdeo
added branching rules
6b202d0
@vinitshahdeo
renamed important resources to useful resources
685481c
@vinitshahdeo
added hall of fame
5588d77
@vinitshahdeo
added admin pic
95ad515
@vinitshahdeo
added admin info
a07944d
@vinitshahdeo
added link to admin's pic
94e8580
@vinitshahdeo
added missing mentor's info
0efb0ce
@vinitshahdeo
Merge pull request #24 from vinitshahdeo/feature/documentation
2def85b 
Added branching info
@vinitshahdeo
added new mentor's name
f17453d
@vinitshahdeo
added link to resources for node.js
3f44799
@vinitshahdeo
Merge pull request #28 from vinitshahdeo/feature/documentation
177bf01 
Updated README.md
prettifier[bot] and others added 24 commits March 7, 2020 14:59
Format 61f714f
3108c24
@vinitshahdeo
fixed font weight issue
0c2a1c3
Format 0c2a1c3
d1e9c19
@vinitshahdeo
removed extra *
0cc49ee
@vinitshahdeo
added rgsoc snippet
e645f24
Format e645f24
9c519fa
Format #134
cc3e742
Format #134
327c842
@vinitshahdeo
fixed issues in .md rendering
546ca41
@vinitshahdeo
added a snippet for rgsoc
a11411a
@vinitshahdeo
added info+logo for RGSOC
75db82e
@vinitshahdeo
added link to tweet
7994fe4
@vinitshahdeo
Merge pull request #140 from vinitshahdeo/docs/rgsoc-1
4120feb 
Added info about RGSoC
@vinitshahdeo
added link to RGSoC issue
6cd2c9e
@vinitshahdeo
added rgsoc logo
d1562e1
@vinitshahdeo
added rgsoc logo
a7aca67
@vinitshahdeo
added link to rgsoc issue
c23264f
added links to hall of fame badge
68bdd1f
@vinitshahdeo
updated COVID-19 precautions
2ce60dd
@vinitshahdeo
added a note on COVID-19
42402e5
@vinitshahdeo
added "Avoid Handshakes, Do Namastey" note
721ba91
@ayan-biswas0412
first commit to my master
a4ffef8
@ayan-biswas0412
frontend user admin login form created
4022813
@ayan-biswas0412
firebase login added
03234d6
@auto-assign auto-assign bot requested a review from vinitshahdeo March 22, 2020 18:32
PragatiVerma18
PragatiVerma18 suggested changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@PragatiVerma18 PragatiVerma18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @ayan-biswas0412 please make a PR to the the feature/frontend branch and update your current working branch by fetching change from the upstream. It's showing changes from 65 commits, which are not all done by you.

@ayan-biswas0412
Copy link
Author

I have done my PR aginst your review #219 check it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinitshahdeo vinitshahdeo Awaiting requested review from vinitshahdeo

@PragatiVerma18 PragatiVerma18 Awaiting requested review from PragatiVerma18

Assignees

@vinitshahdeo vinitshahdeo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayan-biswas0412 @PragatiVerma18 @vinitshahdeo