-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #54 #203
Merged
harshita19244
merged 4 commits into
vinitshahdeo:feature/frontend
from
IuliaElizaS:overflowAlarm
Jan 21, 2021
Merged
Fix issue #54 #203
harshita19244
merged 4 commits into
vinitshahdeo:feature/frontend
from
IuliaElizaS:overflowAlarm
Jan 21, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request! |
vinitshahdeo
approved these changes
Mar 31, 2020
@jainpawan21 @ArpitKotecha please review and merge if all is well. |
ArpitKotecha
suggested changes
Apr 10, 2020
IuliaElizaS
force-pushed
the
overflowAlarm
branch
from
April 14, 2020 12:25
03a8210
to
d1db354
Compare
@IuliaElizaS Please resolve the conflicts. |
ArpitKotecha
suggested changes
Apr 14, 2020
IuliaElizaS
force-pushed
the
overflowAlarm
branch
from
April 16, 2020 09:38
ca510c7
to
d1db354
Compare
IuliaElizaS
force-pushed
the
overflowAlarm
branch
from
April 17, 2020 15:03
e3c4169
to
f011585
Compare
harshita19244
approved these changes
Jan 21, 2021
Congrats on merging your first pull request! 🙌🎉⚡️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an alarm to indicate that the tank is about to overflow
Fixes # 54
Type of change
Please delete options that are not relevant.
Checklist:
Reviewer: Vinit Shahdeo