Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #54 #203

Merged
Merged

Conversation

IuliaElizaS
Copy link

Description

Adds an alarm to indicate that the tank is about to overflow

Fixes # 54

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Reviewer: Vinit Shahdeo

@welcome
Copy link

welcome bot commented Mar 21, 2020

Thanks for opening this pull request!
Please add @vinitshahdeo as a reviewer if you haven't added.

@PragatiVerma18
Copy link
Contributor

@jainpawan21 @ArpitKotecha please review and merge if all is well.

react-frontend/src/actions/tankActions.js Outdated Show resolved Hide resolved
react-frontend/src/actions/alarms.js Outdated Show resolved Hide resolved
@ArpitKotecha
Copy link
Contributor

@IuliaElizaS Please resolve the conflicts.

@ArpitKotecha ArpitKotecha self-requested a review April 14, 2020 12:32
react-frontend/src/pages/Home.js Outdated Show resolved Hide resolved
@harshita19244 harshita19244 merged commit c0f72e2 into vinitshahdeo:feature/frontend Jan 21, 2021
@welcome
Copy link

welcome bot commented Jan 21, 2021

Congrats on merging your first pull request! 🙌🎉⚡️
Show some love by starring a few of my repositories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants