Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UML Diagram in README.md #198

Open
wants to merge 4 commits into
base: feature/frontend
Choose a base branch
from

Conversation

habeeba-naaz
Copy link

Description

Please review and let me know any changes to be done.
Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context.
List any dependencies that are required for this change.

Fixes #50

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Reviewer: Vinit Shahdeo

@habeeba-naaz
Copy link
Author

Water-Monitoring-System

Copy link
Contributor

@PragatiVerma18 PragatiVerma18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow proper markdown for adding an image. Rest all looks good in the image.

@habeeba-naaz
Copy link
Author

Please share example to do that

Copy link
Contributor

@PragatiVerma18 PragatiVerma18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PragatiVerma18
Copy link
Contributor

@habeeba-naaz since UML diagram is a part of the documentation, please make a PR to feature/documentation branch.

@nandikajain
Copy link
Contributor

@habeeba-naaz ??

@harshita19244
Copy link
Contributor

@habeeba-naaz please make pr to feature/documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants