Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/backend node #164

Closed
wants to merge 23 commits into from
Closed

Feature/backend node #164

wants to merge 23 commits into from

Conversation

lakshyajit165
Copy link

@lakshyajit165 lakshyajit165 commented Mar 15, 2020 •
edited
Loading

Modified the tank reading mongoose Schema

Fixes #162

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings

Reviewer: Vinit Shahdeo and Arpit Jain

vinitshahdeo and others added 22 commits March 7, 2020 16:07
@welcome
Copy link

welcome bot commented Mar 15, 2020

Thanks for opening this pull request!
Please add @vinitshahdeo as a reviewer if you haven't added.

@auto-assign auto-assign bot requested a review from vinitshahdeo March 15, 2020 11:35
PragatiVerma18
PragatiVerma18 suggested changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@PragatiVerma18 PragatiVerma18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update your fork and then make your changes. You are pushing 22 commit changes, which I can't review.

@PragatiVerma18 PragatiVerma18 added gssoc20 Welcome to GirlScript Summer of Code 2020 hard hard level issue labels Mar 18, 2020
@PragatiVerma18
Copy link
Contributor

@ArpitKotecha @amaaniqbal please look for nodeJS changes. I am not much familiar with nodeJS.

@lakshyajit165
Copy link
Author

@PragatiVerma18, @ArpitKotecha, @amaaniqbal. Could you help me out on this? I am not able to understand how to proceed now. I had my fork updated when I committed, could you help me by reviewing my commit from the commit hash?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PragatiVerma18 PragatiVerma18 PragatiVerma18 requested changes

@vinitshahdeo vinitshahdeo Awaiting requested review from vinitshahdeo

Assignees

@vinitshahdeo vinitshahdeo

Labels
gssoc20 Welcome to GirlScript Summer of Code 2020 hard hard level issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lakshyajit165 @PragatiVerma18 @vinitshahdeo