Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated name in api/package.json file #110

Merged
merged 3 commits into from
Mar 5, 2020
Merged

updated name in api/package.json file #110

merged 3 commits into from
Mar 5, 2020

Conversation

Sbabureddy
Copy link

@Sbabureddy Sbabureddy commented Mar 3, 2020

Description

Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context.
List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • updated package name in api/package.json file in feature/backend-node branch

Checklist:

  • [ x] My code follows the style guidelines of this project
  • [x ] I have performed a self-review of my own code
  • [x ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Reviewer: Vinit Shahdeo

@welcome
Copy link

welcome bot commented Mar 3, 2020

Thanks for opening this pull request!
Please add @vinitshahdeo as a reviewer if you haven't added.

@auto-assign auto-assign bot requested a review from vinitshahdeo March 3, 2020 18:45
@vinitshahdeo vinitshahdeo changed the base branch from develop to feature/backend-node March 3, 2020 19:02
@vinitshahdeo vinitshahdeo added gssoc20 Welcome to GirlScript Summer of Code 2020 easy Easy issue labels Mar 3, 2020
@@ -1,5 +1,5 @@
{
"name": "web-monitoring-api",
"name": "water-monitoring-system-api",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the name as #113 else LGTM ..:)

Copy link

@YashMeh YashMeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A simple change is being requested.

@Sbabureddy
Copy link
Author

@YashMeh the pull request assigned to me is #104 please look into it once again.

@YashMeh YashMeh merged commit 2727656 into vinitshahdeo:feature/backend-node Mar 5, 2020
@welcome
Copy link

welcome bot commented Mar 5, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Show some love by starring a few of my repositories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy Easy issue gssoc20 Welcome to GirlScript Summer of Code 2020
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants