Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create UI for IP Scanner #168

Open
wants to merge 3 commits into
base: feature/react
Choose a base branch
from

Conversation

AshuKV
Copy link

@AshuKV AshuKV commented Mar 18, 2021

Description

Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context.
List any dependencies that are required for this change.

Fixes #162

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules
  • I have added all the three reviewers: @vinitshahdeo, @Kashish121 & @ishika1727

@welcome
Copy link

welcome bot commented Mar 18, 2021

Thanks for opening this pull request! 🤗
Are you looking for more beginner-friendly issues? Check out this repo.

Hacktoberfest2020

Open Source Love

Check out few other repos below 🚀

inspirational-quotes
SimpleBio
HBD
Map Of India

PS: Please add @vinitshahdeo / @Kashish121 / @ishika1727 as a reviewer if you haven't added.

Copy link
Owner

@vinitshahdeo vinitshahdeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AshuKV Can you please update the PR title and attach screenshots in the PR description?

@AshuKV AshuKV changed the title UI/ip scanner/ashu Create UI for IP Scanner Apr 3, 2021
@AshuKV
Copy link
Author

AshuKV commented Apr 3, 2021

Please see the starter webpage for creating the UI for the port scanner.
image
More work is needed, so I would like to collaborate with others on this issue.

Copy link
Owner

@vinitshahdeo vinitshahdeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ishika1727 / @Kashish121 can you please review this?

Copy link
Owner

@vinitshahdeo vinitshahdeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ishika1727 Please review and merge.

@ishika1727
Copy link
Collaborator

@AshuKV I feel the UI is quite incompete . There is a lot of empty space on right hand side and the spacing are also not good. Please make the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants