Fix certification badge logos disappearing on admin page refresh#97
Merged
vincentmakes merged 1 commit intomainfrom Apr 3, 2026
Merged
Fix certification badge logos disappearing on admin page refresh#97vincentmakes merged 1 commit intomainfrom
vincentmakes merged 1 commit intomainfrom
Conversation
The dataset load endpoint was missing logo_filename and logo_propagate fields in the certifications INSERT statement. Every admin page refresh triggers loadDefaultDatasetOnStartup() which reloads the default dataset, deleting and re-inserting all certifications without their logo data. Bump version to 1.26.3. https://claude.ai/code/session_01D8PEuMaB7Njg1vXurw7wXP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where certification badge logos would disappear when reloading datasets on the admin page. The problem was that the certifications table insert statement was missing the
logo_filenameandlogo_propagatefields, causing these values to be lost during dataset import operations.The fix adds these two fields to the certifications INSERT statement in both the
/api/datasets/:id/loadand/api/importendpoints, ensuring logo data is properly preserved when loading saved datasets.Type of Change
Checklist
Required for all code changes
npm testpasses)package.json,package-lock.json,version.json)CHANGELOG.mdhas been updated with a new entry under the correct versionIf adding or changing user-visible strings
If documentation-only change
https://claude.ai/code/session_01D8PEuMaB7Njg1vXurw7wXP