Skip to content

Fix certification badge logos disappearing on admin page refresh#97

Merged
vincentmakes merged 1 commit intomainfrom
claude/fix-badges-disappearing-a9T9H
Apr 3, 2026
Merged

Fix certification badge logos disappearing on admin page refresh#97
vincentmakes merged 1 commit intomainfrom
claude/fix-badges-disappearing-a9T9H

Conversation

@vincentmakes
Copy link
Copy Markdown
Owner

@vincentmakes vincentmakes commented Apr 3, 2026

Description

Fixes an issue where certification badge logos would disappear when reloading datasets on the admin page. The problem was that the certifications table insert statement was missing the logo_filename and logo_propagate fields, causing these values to be lost during dataset import operations.

The fix adds these two fields to the certifications INSERT statement in both the /api/datasets/:id/load and /api/import endpoints, ensuring logo data is properly preserved when loading saved datasets.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (changes to docs only — no version bump needed)
  • Translation (new or updated language files)
  • Refactoring (no functional changes)

Checklist

Required for all code changes

  • I have tested my changes locally (npm test passes)
  • Version has been bumped in all 3 files (package.json, package-lock.json, version.json)
  • CHANGELOG.md has been updated with a new entry under the correct version

If adding or changing user-visible strings

  • No user-visible strings affected

If documentation-only change

  • Not applicable

https://claude.ai/code/session_01D8PEuMaB7Njg1vXurw7wXP

The dataset load endpoint was missing logo_filename and logo_propagate
fields in the certifications INSERT statement. Every admin page refresh
triggers loadDefaultDatasetOnStartup() which reloads the default dataset,
deleting and re-inserting all certifications without their logo data.

Bump version to 1.26.3.

https://claude.ai/code/session_01D8PEuMaB7Njg1vXurw7wXP
@vincentmakes vincentmakes merged commit eeaab9b into main Apr 3, 2026
3 checks passed
@vincentmakes vincentmakes deleted the claude/fix-badges-disappearing-a9T9H branch April 3, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants