Rebase #1
Merged
Rebase #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR#18991 introduced directly navigating to a DAG when selecting one from the typeahead search results. Unfortunately, the search results also includes DAG owner names, and selecting one of those navigates to a DAG with that name, which almost certainly doesn't exist. This extends the autocompletion endpoint to return the type of result, and adjusts the typeahead selection to use this to know which way to navigate.
The foldable parts were not good. They made links not to work as well as they were not too discoverable. Fixes: #23174
…23877) Currently there are string-value evaluations of `compute`, `nodegroup_role_arn`, and `fargate_pod_execution_role_arn` args in the constructor of `EksCreateClusterOperator`. These args are all listed as a template fields so it's entirely possible that the value(s) passed in to the operator is a Jinja expression or an `XComArg`. Either of these value types could cause a false-negative `ValueError` (in the case of unsupported `compute` values) or a `false-positive` (in the the cases of explicit checks for the *arn values) since the values themselves have not been rendered. This PR moves the evaluations of these args to the `execute()` scope.
String instead of Int see https://docs.readthedocs.io/en/stable/config-file/v2.html
The --verbose and --dry-dun commands caused n --files command to fail and the flag was "artifficial" -it was equivalent to bool flag. the actual files were taken from arguments. This PR fixes it by turning the arguments into multiple ``--file`` commands - each with its own completioin for local files.
Simple refactoring to make the jobs more consistent.
The rest of the page has consistently alphabetized tables. This commit fixes three `extras` that were not alphabetized.
When patching as "checked", we have to use the current version of the pod otherwise we may get an error when trying to patch it, e.g.: ``` Operation cannot be fulfilled on pods \"test-kubernetes-pod-db9eedb7885c40099dd40cd4edc62415\": the object has been modified; please apply your changes to the latest version and try again" ``` This error would not cause a failure of the task, since errors in `cleanup` are suppressed. However, it would fail to patch. I believe one scenario when the pod may be updated is when retrieving xcom, since the sidecar is terminated after extracting the value. Concerning some changes in the tests re the "already_checked" label, it was added to a few "expected pods" recently, when we changed it to patch even in the case of a successful pod. Since we are changing the "patch" code to patch with the latest read on the pod that we have (i.e. using the `remote_pod` variable), and no longer the pod object stored on `k.pod`, the label no longer shows up in those tests (that's because in k.pod isn't actually a read of the remote pod, but just happens to get mutated in the patch function before it is used to actually patch the pod). Further, since the `remote_pod` is a local variable, we can't observe it in tests. So we have to read the pod using k8s api. _But_, our "find pod" function excludes "already checked" pods! So we have to make this configurable. So, now we have a proper integration test for the "already_checked" behavior (there was already a unit test).
It was not clear to me what this really means
main breaks with
`Traceback:
/usr/local/lib/python3.7/importlib/__init__.py:127: in import_module
return _bootstrap._gcd_import(name[level:], package, level)
tests/providers/amazon/aws/hooks/test_cloud_formation.py:31: in <module>
class TestCloudFormationHook(unittest.TestCase):
tests/providers/amazon/aws/hooks/test_cloud_formation.py:67: in TestCloudFormationHook
@mock_cloudformation
/usr/local/lib/python3.7/site-packages/moto/__init__.py:30: in f
module = importlib.import_module(module_name, "moto")
/usr/local/lib/python3.7/importlib/__init__.py:127: in import_module
return _bootstrap._gcd_import(name[level:], package, level)
/usr/local/lib/python3.7/site-packages/moto/cloudformation/__init__.py:1: in <module>
from .models import cloudformation_backends
/usr/local/lib/python3.7/site-packages/moto/cloudformation/models.py:18: in <module>
from .parsing import ResourceMap, OutputMap
/usr/local/lib/python3.7/site-packages/moto/cloudformation/parsing.py:17: in <module>
from moto.apigateway import models # noqa # pylint: disable=all
/usr/local/lib/python3.7/site-packages/moto/apigateway/__init__.py:1: in <module>
from .models import apigateway_backends
/usr/local/lib/python3.7/site-packages/moto/apigateway/models.py:9: in <module>
from openapi_spec_validator import validate_spec
E ModuleNotFoundError: No module named 'openapi_spec_validator'
`
Fix is already in placed in moto getmoto/moto#5165 but version 3.1.11 wasn't released yet
New release of Azure Cosmos library has added typing information and it broke main builds with mypy verification.
The change of the release workflow in #23928 removed the reason why we should have rebase workflow possible. We only needed to do rebase when we merged test branch into stable branch and since we are doing it manually, there is no more reeason to have it in the GitHub UI.
* UI fix for null task instances * improve tests without global vars * fix test data
* Show details button and wrap on LegendRow. * Update following brent review * Fix display on small width * Rotate icon for a 'ReadLess' effect
This fetches all TIs for a given task across dag runs, leading to signifincatly faster response times. It also fixes a bug where Nones were being passed to the UI when a new task was added to a DAG with exiting runs.
There's are two code blocks with identical text in the helm-chart docs. This commit removes one of them.
Result is here: #24168
That Also includes regenerating the breeze output images.
* Change execution_date to data_interval_start in BigQueryInsertJobOperator job_id Change-Id: Ie1f3bba701169ceb2b39d693da320564de145c0c * Change jinja template path to relative path Change-Id: I6cced215124f69e9f4edf8ac08bb71d3ec3c8afc Co-authored-by: Bartlomiej Hirsz <bartomiejh@google.com>
…ataflowStartSqlJobOperator (#24046)
The constructor for `GithubSensor` was instantiating `GitHubOperator` to use its `execute()` method as the driver for the result of the sensor's `poke()` logic. However, this could yield a `DuplicateTaskIdFound` when used in DAGs. This PR updates the `GithubSensor` to use the `GithubHook` instead.
Breeze when started produced three warnings that were harmless, but we should fix them to remove "false positives".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.